rel

rel copied to clipboard

Currently there is no way at least for migrations to create/drop schemas for databases that support them like PostgreSQL

databases that support them like PostgreSQL

did you do research other than PostgreSQL?

I would love to have this if it's possible

I think only PostgreSQL and MSSQL support this, tho I have not used MSSQL for quite some time already :)

Looks like MySQL driver also support db creation https://github.com/go-sql-driver/mysql/blob/6cf3092b0e12f6e197de3ed6aa2acfeac322a9bb/driver_test.go#L227-L228

for sqlite3, maybe we can just connect to db and schema will be created, for deleting schema, we can delete the file

First step would be probably just implement for ones who support schemas and for others just print warnings

Maybe for MySQL and sqlite3 use schema as prefix for table names?

ah, looks like I miss understood schema for database 🤦

Maybe for MySQL and sqlite3 use schema as prefix for table names?

if there's a way to make this API not available in this adapter maybe better, like making the CreateSchema function adapter specific 🤔

how about application usage? how will it refer to correct schema? I think we can exec SET search_path TO schema during adpater initialization, but I'm wondering if it's a good idea 🤔

If you want to use multiple schemas in single app search_path is not very useful. Migration is just one part - if adapter does not support it can just ignore these commands. Other part is table names need to prefixed with <schema>.<table> so either we need new function to interface that would like there is Table() string to also have Schema() string and adapter than could decide on how to concatenate them like for postgresql it would generate: "schema"."table" for mssql - [schema].[table] and for mysql and sqlite3 it could generate just table name schema_table

sorry for late respond 🙏

what do you think if we use Table() string to specify schema? simply returns <schema>.<table> seems, similar approach is used in activerecord https://stackoverflow.com/a/35945716/7678169

There will be problem handling this in adapters if only Table() is used as in sqlite and mysql schema should be used as prefix instead.

I was thinking we don't have to support compatibility for all adapters, because even if we make it compatible for repository, I don't think there's a way to make it compatible for migration since table name is defined manually.

so I think it's about how far we want to support the compatibility, is it okay for migration to be not compatible? is it okay for this feature to be adapter specific? 🤔

Probably it would be ok also to use "." in Table for this and mysql, sqlite that does not support schemas could just use schema as table prefix

sounds good to me

~~When looking at code probably best way to do this would be moving escaping of the table name to Quoter interface by adding method Table(string) string in addition to ID and Value methods. What do you think?~~

Looks like better as option in Buffer type