validator

validator copied to clipboard

issue introduced in #707

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

• [x] Tests exist or have been written that cover this particular change.

@go-playground/admins

Coverage decreased (-0.005%) to 74.172% when pulling 5fbd8503fed687f99e168450c4f2c21d8e8d78ca on xqbumu:patch-1 into 9e2ea4038020b5c7e3802a21cfa4e3afcfdcd276 on go-playground:master.

Can you please make similar change in ValidationErrors.Error? Forced type conversion to concrete unexported type prevents using mocks when testing for returned errors.

Can you please make similar change in ValidationErrors.Error? Forced type conversion to concrete unexported type prevents using mocks when testing for returned errors.

Maybe we can delete the fe in ValidationErrors.Error ? @powerman

Maybe we can delete the fe in ValidationErrors.Error ? @powerman

Yep, ve[i].Error() should works just fine.

@xqbumu Thanks! @deankarn Can you please merge this? (BTW, you probably should add 1.16 to testing matrix.)

Not sure if this is still close enough to be merged/merged with minor edits, but would it be possible for this to also cover this type assertion?

If not, I would be happy to make a PR that (tries to) address that individually/all these issues at once.

I'm getting the same problem. Please, merge this.