render icon indicating copy to clipboard operation
render copied to clipboard

Published 20 hours ago • verified publisher icon go-chi

Support Content ContentTypeForm

Open yohei1126 opened this issue 8 years ago • 7 comments

decorder does not support application/x-www-form-urlencoded yet https://github.com/go-chi/render/blob/7bbdb19f4016118d23bc31d6d33dc1dd517c6b2e/decoder.go#L28

yohei1126 avatar Nov 03 '17 06:11 yohei1126

#4 ?

VojtechVitek avatar Nov 03 '17 18:11 VojtechVitek

Mind testing the PR please?

VojtechVitek avatar Nov 03 '17 18:11 VojtechVitek

thanks!

yohei1126 avatar Nov 03 '17 22:11 yohei1126

Would be nice to close this after we merge #4. Any help with testing it would be appreciated.

VojtechVitek avatar Nov 03 '17 22:11 VojtechVitek

no test code for #4?

yohei1126 avatar Nov 03 '17 22:11 yohei1126

@yohei1126 There's no test code anywhere in this codebase. I didn't want to introduce my testing preferences onto the code, as I'd use Testify by default.

syntaqx avatar Nov 17 '17 21:11 syntaqx

@VojtechVitek If you're concerned about testing on it, if it makes you feel any better, that code has been running in production for quite some time and hasn't had any issues.

syntaqx avatar Nov 17 '17 21:11 syntaqx