wav icon indicating copy to clipboard operation
wav copied to clipboard

Published 20 hours ago • verified publisher icon go-audio

Return error of ReadInfo()

Open glaslos opened this issue 7 years ago • 1 comments

What is the reasoning behind not returning the error here?

func (d *Decoder) ReadInfo() {
	d.err = d.readHeaders()
}

glaslos avatar May 16 '18 08:05 glaslos

@glaslos not a great reason, the idea is that d.Err() is usually the safe way to check for errors, in this case, I think we should change the API to also return an error.

mattetti avatar May 31 '18 03:05 mattetti