gno icon indicating copy to clipboard operation
gno copied to clipboard

Published 20 hours ago • verified publisher icon gnolang

chore: replace all occurence of port 3665{6,7,8} to 2665{6,7,8}

Open albttx opened this issue 1 year ago • 4 comments 

s/36657/26657/g

I believe the port 36657 come because there was multiple testnet on the same server, so the port have been put to 36657.

tendermint default port is 266* and i believe we should keep everything conform to it.

I let test3 compatible with 26657 AND 36657 for legacy purpose

Contributors' checklist...
  • [ ] Added new tests, or not needed, or not feasible
  • [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [ ] Updated the official documentation or not needed
  • [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [ ] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests
  • [ ] Added new benchmarks to generated graphs, if any. More info here.

albttx avatar May 23 '24 14:05 albttx

Will update depending on CI response

albttx avatar May 23 '24 14:05 albttx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.33%. Comparing base (e4b39f9) to head (92dffc5). Report is 19 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2178      +/-   ##
==========================================
+ Coverage   49.00%   49.33%   +0.32%     
==========================================
  Files         576      576              
  Lines       77581    78336     +755     
==========================================
+ Hits        38022    38650     +628     
- Misses      36476    36568      +92     
- Partials     3083     3118      +35
Flag Coverage Δ
contribs/gnodev 24.18% <ø> (+0.03%) :arrow_up:
contribs/gnofaucet 14.46% <ø> (-0.86%) :arrow_down:
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.68% <ø> (ø)
misc/loop 0.00% <ø> (ø)
tm2 54.56% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 23 '24 14:05 codecov[bot]

@thehowl is this test failing "normal" https://github.com/gnolang/gno/actions/runs/9210109774/job/25336315992?pr=2178

albttx avatar May 23 '24 17:05 albttx

@albttx didn't finish the comment, but no it's not normal

the test is bad (it does an actual connection to the actual test3 node, we are aware), you should probably makes sure it keeps connecting to 36657...

thehowl avatar May 23 '24 21:05 thehowl

@thehowl Deploying with https://github.com/gnolang/gno/pull/2178/files#diff-4d1103f730f8cf1eb77c7f7f1ccb5b28bd0eabd3d9bebd10e459a3fdb6ebae64R30 should do the trick ;)

I can do it if you want :)

albttx avatar May 24 '24 11:05 albttx

The primary reason, iirc, was not to run multiple services on the same server but to clearly distinguish between a production instance and a development instance. It should be okay to consolidate this and depend solely on hosts and chain ID.

moul avatar May 24 '24 15:05 moul

The primary reason, iirc, was not to run multiple services on the same server but to clearly distinguish between a production instance and a development instance. It should be okay to consolidate this and depend solely on hosts and chain ID.

@moul Ok, i thought it was the reasons. Nonetheless i believe the RPC port should never be exposed publicly without a proxy in front.

albttx avatar May 27 '24 09:05 albttx