gno icon indicating copy to clipboard operation
gno copied to clipboard

Published 20 hours ago • verified publisher icon gnolang

chore(ci): test start.sh for portal-loop

Open albttx opened this issue 1 year ago • 3 comments

Contributors' checklist...
  • [ ] Added new tests, or not needed, or not feasible
  • [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [ ] Updated the official documentation or not needed
  • [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [ ] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests
  • [ ] Added new benchmarks to generated graphs, if any. More info here.

albttx avatar May 09 '24 09:05 albttx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.17%. Comparing base (5b768db) to head (a988174). Report is 18 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2064   +/-   ##
=======================================
  Coverage   60.16%   60.17%           
=======================================
  Files         561      561           
  Lines       74999    74999           
=======================================
+ Hits        45122    45128    +6     
+ Misses      26502    26493    -9     
- Partials     3375     3378    +3
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) :arrow_down:
gno.land 64.75% <ø> (ø)
gnovm 64.13% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.07% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 09:05 codecov[bot]

review is ready @zivkovicmilos :)

Full testing of portal loop :)

albttx avatar May 11 '24 09:05 albttx

Thanks @moul for review, everything is updated + pull origin master --no-rebase

albttx avatar May 12 '24 21:05 albttx

blocked by https://github.com/gnolang/gno/pull/2199

albttx avatar May 27 '24 08:05 albttx

@ajnavarro @thehowl it's rebased :) ready for last review / merge

albttx avatar Jul 31 '24 10:07 albttx

@ajnavarro I'll let you re-review as you already did it, feel free to ping me for another pair of eyes or second opinion :)

thehowl avatar Jul 31 '24 17:07 thehowl

I am summoning @sw360cab for proper feedback.

ajnavarro avatar Aug 02 '24 16:08 ajnavarro