glue icon indicating copy to clipboard operation
glue copied to clipboard

glue 1.19.0 broke jdaviz (cubeviz)

Open pllim opened this issue 1 year ago • 3 comments

Describe the bug

CI failure as reported in:

  • https://github.com/spacetelescope/jdaviz/issues/2805

To Reproduce

Install glue-core 1.19 and jdaviz from main, then run jdaviz test suite.

Expected behavior

Jdaviz CI should not fail.

pllim avatar Apr 16 '24 18:04 pllim

These PRs were highlights in release notes.

  • #2481
  • #2478
  • #2480
  • #2475
  • #2479

jdaviz does test against dev version of glue stack including glue-core and its devdeps job passed just yesterday (https://github.com/spacetelescope/jdaviz/actions/runs/8690877255/job/23831779573), so whatever that is failing jdaviz must have been merged and released before we had a chance to test against glue-core dev again.

pllim avatar Apr 16 '24 18:04 pllim

So I think that narrowed it down to either of these (and @rosteen came to the same conclusion as well):

  • #2478
  • #2480

cc @astrofrog

pllim avatar Apr 16 '24 18:04 pllim

I can git bisect it later and see what caused it

astrofrog avatar Apr 16 '24 19:04 astrofrog