For now this makes it possible to apply an arbitrary affine transform to the image viewport.

• [x] Also apply transformations to selections (check how this is done for polar selections as we can likely re-use this)
• [x] Clean up API in compute_fixed_resolution_buffer

To do once things work on the jdaviz side:

• [ ] Fix rotation of markers in Matplotlib viewers
• [ ] Update WCS labels in Matplotlib viewer - we should do this by developing an APE-14-compliant rotated WCS class and adding it to the WCS at the last minute.

Codecov Report

Merging #2310 (915a404) into main (f8c1e96) will decrease coverage by 0.07%. The diff coverage is 42.10%.

:exclamation: Current head 915a404 differs from pull request most recent head a39267d. Consider uploading reports for the commit a39267d to get more accurate results

@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
- Coverage   88.06%   87.98%   -0.08%     
==========================================
  Files         247      247              
  Lines       23476    23511      +35     
==========================================
+ Hits        20673    20687      +14     
- Misses       2803     2824      +21     

Impacted Files	Coverage Δ
glue/viewers/image/layer_artist.py	88.93% <ø> (ø)
glue/core/roi_pretransforms.py	55.38% <27.27%> (-14.39%)	:arrow_down:
glue/core/fixed_resolution_buffer.py	86.04% <60.00%> (-2.48%)	:arrow_down:
glue/viewers/image/viewer.py	91.77% <60.00%> (-1.04%)	:arrow_down:
glue/viewers/image/state.py	91.09% <100.00%> (+0.02%)	:arrow_up:
glue/viewers/matplotlib/mpl_axes.py	90.24% <0.00%> (ø)
glue/conftest.py	64.28% <0.00%> (+1.19%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

When the affine transformation contains a translation things don't work quite right so need to investigate some more.

@dhomeier - just FYI I've now pushed changes here to fix the translation stuff, and I've also simplified the API to have a single 'rotation' on the viewer state instead of allowing the full affine transform to be specified.

I am going to unwatch this to reduce my email traffic. Pls ping me here when this is rdy for another round of Jdaviz testing. Thx!

I am going to close this as jdaviz will be taking a different direction and this was incomplete