glue icon indicating copy to clipboard operation
glue copied to clipboard

Published 20 hours ago • verified publisher icon glue-viz

Initial work on unit support

Open astrofrog opened this issue 3 years ago • 3 comments

This adds initial support for unit conversion in the profile viewer, as a test case that is also useful for jdaviz.

Remaining TODOs:

  • [x] Make sure this works properly with glue-jupyter
  • [x] Add documentation about pluggable conversion classes
  • [ ] Add tests

astrofrog avatar Apr 28 '22 16:04 astrofrog

As mentioned in https://github.com/glue-viz/glue-jupyter/pull/311 I am planning on making the unit conversion pluggable/swappable. More soon!

astrofrog avatar May 03 '22 16:05 astrofrog

When you have coded it, I am gonna throw in some magnitudes to make your life interesting, maybe. 😉

pllim avatar May 03 '22 16:05 pllim

p.s. I think at its current state, this PR broke Specviz parser. I had this installed and was doing something else and it crashed. The error went away when I uninstalled this branch and reinstalled glue-core 1.3.0

pllim avatar May 13 '22 14:05 pllim

I will go ahead and merge this, but @dhomeier feel free to take a look at this anyway if you have time and let me know if you spot anything that needs fixing!

astrofrog avatar Jan 30 '23 10:01 astrofrog