consul-node icon indicating copy to clipboard operation
consul-node copied to clipboard

Do not try to base64 decode empty values

Open jandre opened this issue 11 years ago • 1 comments

It is possible for consul kv items to be empty, e.g. you might get something like

{"CreateIndex":915,"ModifyIndex":915,"LockIndex":0,"Key":"some/key/prefix","Flags":4,"Value":null}

In this case, node-consul will attempt to base64 decode this, which results in an exception being thrown, e.g.:

TypeError: Cannot read property 'length' of null at new Buffer (buffer.js:184:31) at /proj/node_modules/consul-node/lib/kv.js:49:16 ...

This prevents that from happening.

jandre avatar Jul 11 '14 12:07 jandre

Also added an for /v1/catalog/services. See commit log.

jandre avatar Jul 13 '14 14:07 jandre