Alper Polat

Results 35 comments of Alper Polat

I downloaded the binary on my linux machine and tarred it to .tar.gz. Then hosted it myself (`python3 -m http.server`), pulled with curl on the mac and untarred it, works...

I did some more research and if we want to sign it with a key that's maintained by the project, we will have to pay Apple a yearly fee of...

Waiting for https://github.com/prometheus/promu/pull/284 to be finalized and merged, this should come after that. We should re-trigger the pipeline to see if everything passes as intended.

Yep, it is still waiting for Julien's review. But if someone else wants to take a second look and give it approval, that might work too. Otherwise I do not...

Bump, I'd still like to get this forward and can make changes if needed.

Is checking maximum of 40 minor revisions okay? Last I took a look at Go releases, they had like 20 something minor revisions max. ``` for next.minor < 40 {...

Does this need any other work, or is it good to merge?

@SuperQ this could be merged if there is no need for more changes

I took a look at the pipeline and I think the output coming from [end to end test script](https://github.com/prometheus/node_exporter/blob/master/end-to-end-test.sh) is not being used for some comparison. Maybe [check metrics script](https://github.com/prometheus/node_exporter/blob/master/checkmetrics.sh)...