gitlab4j-api icon indicating copy to clipboard operation
gitlab4j-api copied to clipboard

Fix additional long ids

Open Sineaggi opened this issue 1 year ago • 5 comments

Found a few cases where deserialization was throwing errors due to ints being out of out-of-range.

Follow-up to https://github.com/gitlab4j/gitlab4j-api/pull/811

Sineaggi avatar Apr 23 '24 19:04 Sineaggi

The change int -> Long in the models is a good idea, but it is breaking on the 5.x stream. Would it be OK to do this change only on 6.x?

jmini avatar May 02 '24 05:05 jmini

The change int -> Long in the models is a good idea, but it is breaking on the 5.x stream. Would it be OK to do this change only on 6.x?

If by "breaking" you mean fixing something that had no chance of working, then yes. 🙂

gwidion avatar May 02 '24 06:05 gwidion

Using int for the id will work only in on-prem setup (at the beginning, until the system reach the limit of int and then start to overflow).

Probably switching to Long is not hurting readers of this value too much.

jmini avatar May 02 '24 07:05 jmini

Tests seem to be failing for reasons not relate to this change?

Sineaggi avatar May 02 '24 16:05 Sineaggi

The test TestAvatarUpload keeps 502ing

Sineaggi avatar May 06 '24 17:05 Sineaggi

I think the integration tests needs to be reworked… It is too flaky right now.

jmini avatar May 16 '24 07:05 jmini

I finally got a green build and I merged your change to main and 6.x. Thank you 🎉 .

jmini avatar May 16 '24 08:05 jmini