Fix additional long ids
Found a few cases where deserialization was throwing errors due to ints being out of out-of-range.
Follow-up to https://github.com/gitlab4j/gitlab4j-api/pull/811
The change int -> Long in the models is a good idea, but it is breaking on the 5.x stream. Would it be OK to do this change only on 6.x?
The change
int->Longin the models is a good idea, but it is breaking on the5.xstream. Would it be OK to do this change only on6.x?
If by "breaking" you mean fixing something that had no chance of working, then yes. 🙂
Using int for the id will work only in on-prem setup (at the beginning, until the system reach the limit of int and then start to overflow).
Probably switching to Long is not hurting readers of this value too much.
Tests seem to be failing for reasons not relate to this change?
The test TestAvatarUpload keeps 502ing
I think the integration tests needs to be reworked… It is too flaky right now.
I finally got a green build and I merged your change to main and 6.x. Thank you 🎉 .