gitify

gitify copied to clipboard

Proposal

The notification should include the reason (mention, review_requested, etc.) to make it easier as a user to know what the notification is about.

Use case

In some cases, I want to ignore "mention" notifications and wait until I get a "review_requested" notification.

It would generally also be nice to get more context before opening the notification.

Getting this done

I'd be happy to create a PR for this, I just wanted to make sure this was something you guys wanted before I started writing code :)

Tasks

• [ ] Update raiseNativeNotification function
• [ ] Test edge cases (long subject title, etc)

I'd be fine with this unless @manosim would prefer to leave it as is :)

That sounds good - this would only apply when there is 1 new notification and not multiple right? If that's the case, feel free to make the change at

https://github.com/manosim/gitify/blob/b5b358579414b64de18e218095ab7e97175763fb/src/utils/notifications.ts#L66-L71

There is also a helper to get a "friendly reason title" at

https://github.com/manosim/gitify/blob/80dd20bd93cea5a44d526505c0e25a85af3107be/src/utils/github-api.ts#L21-L53

Not sure if this is still a desirable feature, but...

I had a few minutes so did a quick test locally of three ways the notification reason could be added.

Open to feedback as well as alternate suggestions

IMHO it's a power user feature to use this. Most probably don't even think about the notification reason (I haven't even wrapped my head around what they mean, not that it's hard). For me at least, extra content in the notification would be extra noise I wouldn't want. So showing the reason in the notification should be an option... but I have concerns about adding too many options. See https://github.com/gitify-app/gitify/issues/728

Agreed as well, let's keep it simple!