licensed icon indicating copy to clipboard operation
licensed copied to clipboard

Support gradle multi-project

Open civitaspo opened this issue 3 years ago • 3 comments

Signed-off-by: civitaspo [email protected]

Fix https://github.com/github/licensed/issues/301

This PR supports gradle projects with multi-project configuration. The settings.gradle defined in the project was ignored when executing printDependencies, which is a task to output dependencies, so it is now used. Running a Gradle Task without settings.gradle in a project that defines settings.gradle could lead to unintended behavior, so this fix ensures that Gradle Tasks run correctly. Just to make sure that backwards compatibility is not broken, I've tested this on a few projects I manage and found no change in behavior. The support for build.gradle.kts and settings.gradle.kts written in Kotlin mentioned in https://github.com/github/licensed/issues/301 will be done in the next PR after this PR is merged.

civitaspo avatar Mar 01 '22 17:03 civitaspo

@jonabc I will try to add some test cases. This is going to be a bit of a big pull request as there is currently no code to test the behavior of gradle itself. I'll probably add some gradle projects to the repository for testing.

civitaspo avatar Mar 03 '22 02:03 civitaspo

@jonabc Thanks for taking care of it. Test / gradle (11) (pull_request) still haven't passed, so I'll need to fix that a bit more. I've been busy with work and haven't had time to fix it, so please wait a little longer.

civitaspo avatar Mar 15 '22 02:03 civitaspo

@civitaspo no problem at all, I'm just checking in from time to time to see how things are going since I don't have much experience in the problem space 😄

jonabc avatar Mar 15 '22 17:03 jonabc

closing this PR, multi-project support was implemented in https://github.com/github/licensed/pull/583

jonabc avatar Jan 05 '23 17:01 jonabc