linguist icon indicating copy to clipboard operation
linguist copied to clipboard

Published 20 hours ago • verified publisher icon github-linguist

Update ace mode path for tests

Open lildude opened this issue 3 years ago • 2 comments

The upstream directory structure was changed in https://github.com/ajaxorg/ace/pull/4851 which means we're looking in the wrong place for all the languages supported by the Ace editor. We now need to look in the old location for jsoniq and xquery and the new location for everything else.

These changes have been made as they plan to release Ace as an NPM.

lildude avatar Aug 08 '22 10:08 lildude

There doesn't appear to be any rationale behind ajaxorg/ace#4851. If upstream makes this sort of change willy-nilly, then it might be wiser to query the latest tagged release, as opposed to HEAD. Doing so will reduce the risk of this happening again, since there's no guarantee such an arbitrary change won't be reverted later.

Alhadis avatar Aug 08 '22 11:08 Alhadis

There doesn't appear to be any rationale behind ajaxorg/ace#4851.

There is now as I asked for one 😁.

Based on this, I think we're good to stay with using HEAD. This has been the first major change like this since we implemented the test so I think we should be good querying both locations for the future.

lildude avatar Aug 10 '22 10:08 lildude