git-scm.com

git-scm.com copied to clipboard

Currently documentation in RTL languages (such as Farsi) show as following:

while the correct mode is:

it can be done by adding direction: rtl; css to container div

@peff I was thinking if this would be a good hacktoberfest candidate, but I've no clue how hard it would be to fix this?

@pedrorijo91 I'm not sure. I guess we'd have to insert this styling only into the pages for RTL translations of the book content. So it would really involve munging the content as it gets sucked in from the progit repo (in lib/tasks/book2.rb).

Partial translations would be tricky, since this would have to be applied partially. But maybe we can just ignore that for the initial attempt.

It may also be tricky for translations which are only done for v1 of the book. I think the import process there is a bit different (though probably it should be able to do something similar).

I guess that would require two things for v2:

• add a new field in all_books at https://github.com/git/git-scm.com/blob/master/lib/tasks/book2.rake#L167 with the direction
• tweak the html generation to insert it in each generated page.