Luigi Pertoldi

Results 32 comments of Luigi Pertoldi

In my test I randomly get true or false in `is_valid_0vbb` for SiPM data. I can work on a MWE tomorrow. @gracesong312 do you pre-allocate empty columns for the output...

Nice! Performance of the LGDO conversion methods is also a topic for https://github.com/legend-exp/legend-pydataobj/pull/30 by @MoritzNeuberger. Did anyone try profiling the code to spot straightforward bottlenecks?

Good point @slwatkins. What about disabling JIT in unit tests? Would that fix the problem?

Thumbs up! Can you open a PR with this? Maybe we merge #399 first.

I also think that, since many new features will come, we should think about how to refactor the code to make it more readable. It's very hard at the moment...

We should also evaluate the performance and make sure that using the data loader does not add significant overhead to just manually loading the data from a known list of...

Also: `.load()` currently fails if the provided entry list (Pandas DataFrame) is not properly indexed (e.g. if it has been previously filtered). This can be fixed on the user side...

I would argue that we should try to avoid having LEGEND-specific stuff in the DataLoader, such as pylegendmeta.