godot-dockable-container icon indicating copy to clipboard operation
godot-dockable-container copied to clipboard

add tab title rename logic

Open Lemonbrush opened this issue 1 year ago • 1 comments

I added tab title rename logic It allows you to rename tabs without affecting tab node paths as it is now To be honest, this solution looks bad. If you have an advice on haw to improve it I would be happy to make an update but now it is something at least

Lemonbrush avatar Jun 28 '24 20:06 Lemonbrush

Hey @Lemonbrush, thanks for the contribution! Renaming tabs is a very nice addition, much needed if you ask me.

If you have an advice on haw to improve it I would be happy to make an update but now it is something at least

I think tab naming should be kept in the DockableLayout resource instead of the DockableContainer. This way it would be easily editable without any code and would get properly serialized.

Not sure if it makes more sense to put this in the DockableLayout itself, like hidden_tabs is, or if it makes sense to put this in the DockableLayoutPanel. I guess the first option is better, because one could rearrange the panels several times and the name mapping would be kept in the same place, much simpler. What do you think?

gilzoide avatar Aug 11 '24 16:08 gilzoide