sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref(js): Remove acceptance test env and related code

Open evanpurkhiser opened this issue 4 months ago • 2 comments

IS_ACCEPTANCE_TEST and its associated dynamic text/static text behavior were removed from the codebase.

Changes include:

  • The IS_ACCEPTANCE_TEST constant was removed from static/app/constants/index.tsx.
  • Build configurations in rspack.config.ts and config/build-chartcuterie.ts were updated to remove references to IS_ACCEPTANCE_TEST.
  • The getDynamicText utility in static/app/utils/getDynamicText.tsx was simplified to always return the value parameter, eliminating the conditional fixed text behavior. Its corresponding test file, static/app/utils/getDynamicText.spec.tsx, was deleted.
  • The testableTransition utility in static/app/utils/testableTransition.tsx was simplified to always return the provided transition, removing logic that conditionally disabled animations for acceptance tests.
  • The useResizable hook and related constants (SECONDARY_SIDEBAR_MIN_WIDTH, SECONDARY_SIDEBAR_MAX_WIDTH) were removed, simplifying static/app/views/nav/secondary/secondarySidebar.tsx and static/app/views/nav/sidebar.tsx.
  • Conditional logic relying on deprecateTransactionAlerts was removed from static/app/views/discover/savedQuery/index.tsx, static/app/views/performance/transactionSummary/header.tsx, and static/app/views/performance/vitalDetail/vitalDetailContent.tsx.
  • Test files static/app/views/explore/multiQueryMode/queryConstructors/menu.tsx and static/app/views/explore/multiQueryMode/locationUtils.tsx were updated, and static/app/views/explore/multiQueryMode/queryRow.tsx was adjusted to remove duplicate/delete query functionality.
  • The build-acceptance script in package.json was modified to remove only the IS_ACCEPTANCE_TEST=1 environment variable, preserving the script itself.

This streamlines the codebase by removing legacy testing-specific conditional rendering and animation logic.

evanpurkhiser avatar Jun 13 '25 18:06 evanpurkhiser