sentry icon indicating copy to clipboard operation
sentry copied to clipboard

cleanup(group-attributes): Remove the option to send updates to kafka

Open snigdhas opened this issue 1 year ago • 0 comments

Removing the option issues.group_attributes.send_kafka which gates whether snapshots are sent to kafka to update the fields in GroupAttributes. The option is enabled globally and has been on for a few months. This PR enabled the options in tests and cleans up any references to the the options.

Some unit tests for daily summary and weekly reports modified groups outside of the with self.options({"issues.group_attributes.send_kafka": True}): block, meaning those changes were not published to GroupAttributes. Since the queries for these two features uses a join on GroupAttributes, the tested behavior was inaccurate. Namely, the tests expected resolved groups to appear in the generated reports. This PR also fixes those inconsistencies.

snigdhas avatar Oct 18 '24 00:10 snigdhas