sentry icon indicating copy to clipboard operation
sentry copied to clipboard

Published 20 hours ago β€’ verified publisher icon getsentry

Remove Sentry warnings and GCP logs for throttled queries

Open xurui-c opened this issue 1 year ago β€’ 2 comments

Snuba throttles queries in the magnitude of 10k-20k. A previous PR emits a warning to Sentry and logs to GCP for every throttled query, and thus has the potential to overwhelm Sentry/GCP. This PR removes the warnings and logs in case we have an incident.

xurui-c avatar Jun 29 '24 00:06 xurui-c

πŸ” Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

πŸ“„ File: src/sentry/utils/snuba.py

Function Unhandled Issue
_bulk_snuba_query RateLimitExceeded: Query on could not be run due to allocation policies, info: {'details': {'ReferrerGuardRailPolicy... ...
Event Count: 120
_bulk_snuba_query RateLimitExceeded: Query on could not be run due to allocation policies, info: {'details': {'ConcurrentRateLimitAllo... ...
Event Count: 53
_bulk_snuba_query QueryMemoryLimitExceeded: DB::Exception: Received from snuba-outcomes-mz-1-3:9000. DB::Exception: Memory limit (for query) ... ...
Event Count: 49

Did you find this useful? React with a πŸ‘ or πŸ‘Ž

sentry-io[bot] avatar Jun 29 '24 00:06 sentry-io[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.02%. Comparing base (50354c5) to head (e7e1ce8).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #73549      +/-   ##
==========================================
+ Coverage   77.01%   78.02%   +1.00%     
==========================================
  Files        6638     6638              
  Lines      296878   296877       -1     
  Branches    51122    51122              
==========================================
+ Hits       228655   231636    +2981     
+ Misses      61817    58967    -2850     
+ Partials     6406     6274     -132
Files Coverage Ξ”
src/sentry/utils/snuba.py 89.64% <ΓΈ> (+0.42%) :arrow_up:

... and 271 files with indirect coverage changes

codecov[bot] avatar Jun 29 '24 00:06 codecov[bot]