sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(group-attributes): Add migration to backfill group priority in GroupAttributes

Open snigdhas opened this issue 1 year ago • 11 comments

This is adapted from 0641_backfill_group_attributes to add Group.priority and Group.first_release to the GroupAttributes table for SaaS, ST, and self hosted customers.

snigdhas avatar Apr 16 '24 23:04 snigdhas

This PR has a migration; here is the generated SQL for src/sentry/migrations/0701_backfill_group_priority_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar Apr 18 '24 17:04 github-actions[bot]

I thought I remember us seeing that we needed another column or two in this table

Hm, do you know which columns were missing? It makes sense to add them and do the backfill at once if possible

snigdhas avatar May 02 '24 17:05 snigdhas

This PR has a migration; here is the generated SQL for src/sentry/migrations/0714_backfill_group_priority_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar May 06 '24 23:05 github-actions[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar May 28 '24 07:05 getsantry[bot]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0729_backfill_group_info_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar Jun 13 '24 22:06 github-actions[bot]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0730_backfill_group_info_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar Jun 14 '24 04:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.18%. Comparing base (fe9162b) to head (7c28b2c). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #69072      +/-   ##
==========================================
+ Coverage   78.10%   78.18%   +0.07%     
==========================================
  Files        6661     6659       -2     
  Lines      297761   297394     -367     
  Branches    51260    51179      -81     
==========================================
- Hits       232579   232521      -58     
+ Misses      58870    58558     -312     
- Partials     6312     6315       +3     

see 28 files with indirect coverage changes

codecov[bot] avatar Jun 14 '24 05:06 codecov[bot]

We've added priority and first_release_id from the Group table to GroupAttributes. That should be the only columns we're adding as part of this, so we're ready to finalize the backfill. I'll work with sns/ops before running it to ensure we're ready for a potential backlog.

snigdhas avatar Jun 14 '24 17:06 snigdhas

We've added priority and first_release_id from the Group table to GroupAttributes. That should be the only columns we're adding as part of this, so we're ready to finalize the backfill. I'll work with sns/ops before running it to ensure we're ready for a potential backlog.

I don't see first_release_id here?

wedamija avatar Jun 17 '24 17:06 wedamija

ah I think that got lost in one of the many merge/regenerates - thanks!

snigdhas avatar Jun 18 '24 18:06 snigdhas

This PR has a migration; here is the generated SQL for src/sentry/migrations/0732_backfill_group_info_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar Jun 18 '24 18:06 github-actions[bot]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0734_backfill_group_info_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar Jul 09 '24 00:07 github-actions[bot]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0736_backfill_group_info_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar Jul 10 '24 22:07 github-actions[bot]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0738_backfill_group_info_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar Jul 11 '24 23:07 github-actions[bot]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0739_backfill_group_info_to_group_attributes.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

github-actions[bot] avatar Jul 12 '24 17:07 github-actions[bot]