sentry icon indicating copy to clipboard operation
sentry copied to clipboard

fix(tests): Adding query tag values as strings from clickhouse

Open andriisoldatenko opened this issue 3 years ago • 1 comments

This PR un-skip existing tests (there is a new pytest marker broken_under_tags_values_as_strings that we use to skip tests when the testsuite is running in "tags values are strings" mode) and make them pass.

Also get rid of direct uses of _send_bucket and replace them with store_metric.

andriisoldatenko avatar Sep 16 '22 16:09 andriisoldatenko

Thanks for putting this up! much cleaner i am thinking of maybe we should freeze_time so we prevent flaky tests but I leave this up to you, we could also do it in its separate PR

ahmedetefy avatar Sep 19 '22 15:09 ahmedetefy