sentry icon indicating copy to clipboard operation
sentry copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

feat(notifications): remove notification default logic

Open scefali opened this issue 3 years ago • 1 comments

We don't need logic on the fron-end to have a default provider because the backend handles proving defaults. And if no providers are enabled at all, then we just don't even render the form input where we show which providers are available.

scefali avatar Aug 05 '22 20:08 scefali

Oh I added this to solve the problem where we show -- even though it should show the default Email.

https://user-images.githubusercontent.com/19944378/183158277-5a25d0f7-aac1-437f-97d0-b16385fb48ec.mov

97varun avatar Aug 05 '22 20:08 97varun

@97varun Good catch! I missed that case. It fixes itself when you reload the page but if you turn a notification on after it's off, we need the front-end default.

scefali avatar Aug 09 '22 16:08 scefali