sentry

sentry copied to clipboard

Since the backfill (https://github.com/getsentry/sentry/pull/37321) for slack is complete, we can default to Slack being enabled for everyone.

@scefali I don't understand this fully but we might be making assumptions about the defaults in a couple of places (that I know of) in the UI.

https://github.com/getsentry/sentry/blob/829ed407c1507c11385a5ef0251e3e6c6fa93d85/static/app/views/settings/account/notifications/notificationSettingsByType.tsx#L217-L220

https://github.com/getsentry/sentry/blob/829ed407c1507c11385a5ef0251e3e6c6fa93d85/static/app/views/settings/account/notifications/utils.tsx#L328-L343

@scefali I don't understand this fully but we might be making assumptions about the defaults in a couple of places (that I know of) in the UI.

https://github.com/getsentry/sentry/blob/829ed407c1507c11385a5ef0251e3e6c6fa93d85/static/app/views/settings/account/notifications/notificationSettingsByType.tsx#L217-L220

https://github.com/getsentry/sentry/blob/829ed407c1507c11385a5ef0251e3e6c6fa93d85/static/app/views/settings/account/notifications/utils.tsx#L328-L343

@97varun I don't really understand why we have that comment. The backend is going to return slack: "always" so we probably don't even need that defaulting logic on the front-end like that. I can remove the defaulting logic on the front-end later in a follow up PR. See: https://github.com/getsentry/sentry/pull/37515

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.