sentry

sentry copied to clipboard

Sentry Issue: SENTRY-V26

UnidiffParseError: Target without source: +++ "b/PinataFarm/Resources/Assets.xcassets/HeadMake/HeadPlaceholders/Angry-selected/leftAngry_selected.imageset/leftAngry_selected@3x \320\272\320\276\320\277\321\226\321\217.png"

(3 additional frame(s) were not displayed)
...
  File "sentry/integrations/bitbucket/repository.py", line 109, in compare_commits
    res = client.compare_commits(name, start_sha, end_sha)
  File "sentry/integrations/bitbucket/client.py", line 147, in compare_commits
    return self.zip_commit_data(repo, commits)
  File "sentry/integrations/bitbucket/client.py", line 113, in zip_commit_data
    commit.update({"patch_set": self.get_commit_filechanges(repo, commit["hash"])})
  File "sentry/integrations/bitbucket/client.py", line 109, in get_commit_filechanges
    return patch_to_file_changes(resp.text)
  File "sentry/utils/patch_set.py", line 14, in patch_to_file_changes
    patch_set = unidiff.PatchSet.from_string(patch)

Target without source: +++ "b/PinataFarm/Resources/Assets.xcassets/HeadMake/HeadPlaceholders/Angry-selected/leftAngry_selected.imageset/leftAngry_selected@3x \320\272\320\276\320\277\321\226\321\217.png"

Spoke with @asottile-sentry and he determined that unidiff doesn't parse quoted names and its worth a patch to unidiff.

potentially the fix is here: https://github.com/matiasb/python-unidiff/blob/3de381b2fb2363ccc8fc2ec548ad63321624d1c3/unidiff/constants.py#L32-L35

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀