sentry icon indicating copy to clipboard operation
sentry copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Cmd+1 tab switching is overriden on /issues/

Open larsnystrom opened this issue 3 years ago • 10 comments

Environment

self-hosted (https://develop.sentry.dev/self-hosted/)

Version

22.6.0

Steps to Reproduce

On macOS:

  1. Open a new tab in your browser (I've tried Firefox and Chrome).
  2. Browse to Sentry in this new tab (I've only tried my self-hosted 22.6.0 installation, but I bet sentry.io has the same problem).
  3. Login.
  4. Open the "Issues" page, i.e. /organizations/.../issues/
  5. Try to switch to the first open tab in your browser by pressing cmd + 1.

Expected Result

The browser switches to the first tab.

Actual Result

Nothing.

larsnystrom avatar Jul 06 '22 07:07 larsnystrom

Routing to @getsentry/open-source for triage. ⏲️

getsentry-release avatar Jul 06 '22 17:07 getsentry-release

Routing to @getsentry/app-frontend for triage. ⏲️

getsentry-release avatar Jul 06 '22 17:07 getsentry-release

Bumping to core UI team as this seems unlikely to be specific to self-hosted.

chadwhitacre avatar Jul 06 '22 17:07 chadwhitacre

This should have been fixed by https://github.com/getsentry/sentry/pull/35554. Just tried on sentry.io on safari, chrome, and Firefox and can't reproduce this.

jennmueng avatar Jul 06 '22 17:07 jennmueng

Hrm, yeah it looks like #35554 should be in 22.6.0. 🤔

Screen Shot 2022-07-06 at 2 42 07 PM

@larsnystrom Are you suuuuuure you are seeing this with 22.6.0? 🧐

chadwhitacre avatar Jul 06 '22 18:07 chadwhitacre

Here's what the footer says:

Skärmavbild 2022-07-07 kl 10 06 52

larsnystrom avatar Jul 07 '22 08:07 larsnystrom

So, I added breakpoints on a few different preventDefault() calls using the Firefox debugger, and the one that is triggered when I do Cmd + 1 is a callback in searchHotkeysListener.tsx:17, called from useHotkeys in useHotkeys.tsx:43, which is called from sentryWrapped in helpers.js:85.

I can confirm that the changes in #35554 is included in for example useHotkeys.tsx.

larsnystrom avatar Jul 07 '22 08:07 larsnystrom

Interesting. Good info, thanks @larsnystrom. Thoughts @jennmueng? 🤔

chadwhitacre avatar Jul 07 '22 19:07 chadwhitacre

@larsnystrom @chadwhitacre I'm double checking and am still not able to reproduce this. We don't have any hotkeys listening on cmd+1 either, only option+1 so I'm a bit surprised you're running into this. Is there any event/action you performed before this bug occurring or does it just happen on initial open of the issues screen? Also, does in happen on other screens where we have a searchbar with hotkeys such as the Discover screen?

jennmueng avatar Jul 08 '22 23:07 jennmueng

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Aug 03 '22 00:08 github-actions[bot]