sentry-unity icon indicating copy to clipboard operation
sentry-unity copied to clipboard

Fix flaky test `ErrorTimeDebounce`

Open bruno-garcia opened this issue 4 years ago • 5 comments

Possible flaky test ErrorTimeDebounce

/Users/runner/work/sentry-unity/sentry-unity/Directory.Build.targets(220,5): error : Test run completed with 1 failing tests. [/Users/runner/work/sentry-unity/sentry-unity/test/Sentry.Unity.Tests/Sentry.Unity.Tests.csproj]
/Users/runner/work/sentry-unity/sentry-unity/Directory.Build.targets(220,5): error :   Expected: False [/Users/runner/work/sentry-unity/sentry-unity/test/Sentry.Unity.Tests/Sentry.Unity.Tests.csproj]
/Users/runner/work/sentry-unity/sentry-unity/Directory.Build.targets(220,5): error :   But was:  True [/Users/runner/work/sentry-unity/sentry-unity/test/Sentry.Unity.Tests/Sentry.Unity.Tests.csproj]
/Users/runner/work/sentry-unity/sentry-unity/Directory.Build.targets(220,5): error :  [/Users/runner/work/sentry-unity/sentry-unity/test/Sentry.Unity.Tests/Sentry.Unity.Tests.csproj]
/Users/runner/work/sentry-unity/sentry-unity/Directory.Build.targets(220,5): error :  [/Users/runner/work/sentry-unity/sentry-unity/test/Sentry.Unity.Tests/Sentry.Unity.Tests.csproj]
/Users/runner/work/sentry-unity/sentry-unity/Directory.Build.targets(220,5): error : ErrorTimeDebounce [/Users/runner/work/sentry-unity/sentry-unity/test/Sentry.Unity.Tests/Sentry.Unity.Tests.csproj]
/Users/runner/work/sentry-unity/sentry-unity/Directory.Build.targets(220,5): error :  [/Users/runner/work/sentry-unity/sentry-unity/test/Sentry.Unity.Tests/Sentry.Unity.Tests.csproj]
Error: Process completed with exit code 1.

bruno-garcia avatar Sep 23 '21 22:09 bruno-garcia

+1 Definitely flakey.

bitsandfoxes avatar Sep 24 '21 08:09 bitsandfoxes

Just got another failed build due to it 🤕

bruno-garcia avatar Sep 24 '21 18:09 bruno-garcia

Debounce functionality is opt-in for the user by default now. Debouce tests return as inconclusive to stop the flakeyness.

bitsandfoxes avatar Jan 18 '22 14:01 bitsandfoxes

Should be fixed together with: https://github.com/getsentry/sentry-unity/issues/501

bitsandfoxes avatar Mar 08 '22 16:03 bitsandfoxes

and https://github.com/getsentry/sentry-unity/pull/685

vaind avatar Apr 13 '22 15:04 vaind