sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

ref(remix): Make `@remix-run/router` a dependency.

Open onurtemizkan opened this issue 2 years ago • 3 comments

Fixes: https://github.com/getsentry/sentry-javascript/issues/10349 Related: https://github.com/getsentry/sentry-javascript/issues/5860 Related: https://github.com/getsentry/sentry-javascript/pull/10458

Removes dynamic loading of react-router-dom and makes @remix-run/router a peer dependency.

We don't need to dynamically load react-router-dom as our TypeScript version is now up-to-date.

onurtemizkan avatar Feb 02 '24 15:02 onurtemizkan

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.77 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.03 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.96 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.54 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (-0.02% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.14 KB (-0.03% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser - Webpack (gzipped) 22.41 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.52 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.48 KB (-0.07% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.25 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.97 KB (-0.06% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.87 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.78 KB (-0.05% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 22.44 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.81 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.05 KB (-0.03% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.16 KB (0%)

github-actions[bot] avatar Feb 02 '24 15:02 github-actions[bot]

Is this ready to merge?

AbhiPrasad avatar Feb 07 '24 18:02 AbhiPrasad

@AbhiPrasad, I think this is ready to go now.

onurtemizkan avatar Feb 16 '24 15:02 onurtemizkan

Let's fix the merge conflicts and we can merge it in! Needs to probably be backported onto v7 as well.

AbhiPrasad avatar Feb 20 '24 19:02 AbhiPrasad

@onurtemizkan mind cherry picking this and opening another PR against v7 branch? we should backport this release.

AbhiPrasad avatar Feb 21 '24 20:02 AbhiPrasad