sentry-java
sentry-java copied to clipboard
Add support for measurements at span level
spans forward measurements to transaction
:scroll: Description
added measurements to spans spans forward measurements to transaction Example transaction
:bulb: Motivation and Context
Fixes https://github.com/getsentry/sentry-java/issues/3180
:green_heart: How did you test it?
Unit tests
:pencil: Checklist
- [x] I reviewed the submitted code.
- [x] I added tests to verify the changes.
- [x] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [x] I updated the docs if needed.
- [x] Review from the native team if needed.
- [x] No breaking change or entry added to the changelog.
- [x] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
:crystal_ball: Next steps
| Fails | |
|---|---|
| :no_entry_sign: | Please consider adding a changelog entry for the next release. |
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Instructions and example for changelog
Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.
Example:
## Unreleased
- Add support for measurements at span level ([#3219](https://github.com/getsentry/sentry-java/pull/3219))
If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.
Generated by :no_entry_sign: dangerJS against 32460b360a34530959ba31f649a1b861461fe7c0
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 428.22 ms | 538.29 ms | 110.06 ms |
| Size | 1.70 MiB | 2.28 MiB | 590.71 KiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0810952c95d04ff7e1b4be22b386cec9c79016d4 | 364.51 ms | 468.08 ms | 103.57 ms |
| 2fad834b55abd8bcbc05a5110122ad3e44fe4f92 | 390.07 ms | 470.80 ms | 80.73 ms |
| 2465853df157c4ad881166804873989c47c10f4d | 422.61 ms | 491.20 ms | 68.58 ms |
| 8ff8fd047e817d4c017858d44c2681c6a8ac4e52 | 432.77 ms | 495.18 ms | 62.41 ms |
| 2465853df157c4ad881166804873989c47c10f4d | 400.64 ms | 465.47 ms | 64.83 ms |
| 5e04ee8e63c5617dbc4c2b9706b866e8823cec20 | 365.26 ms | 448.49 ms | 83.23 ms |
| c554ca260c5f0fa79a30d592f6c0e08a850a5014 | 368.52 ms | 430.74 ms | 62.22 ms |
| 4e290632c3083233d83c696533ee1e0d284dfd42 | 384.14 ms | 447.74 ms | 63.60 ms |
| 0404ea31dd7e67983b3aa0133a0dc4fb6b983884 | 394.73 ms | 461.79 ms | 67.06 ms |
| 0404ea31dd7e67983b3aa0133a0dc4fb6b983884 | 332.47 ms | 401.12 ms | 68.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0810952c95d04ff7e1b4be22b386cec9c79016d4 | 1.72 MiB | 2.27 MiB | 558.21 KiB |
| 2fad834b55abd8bcbc05a5110122ad3e44fe4f92 | 1.72 MiB | 2.29 MiB | 577.53 KiB |
| 2465853df157c4ad881166804873989c47c10f4d | 1.70 MiB | 2.27 MiB | 583.82 KiB |
| 8ff8fd047e817d4c017858d44c2681c6a8ac4e52 | 1.72 MiB | 2.27 MiB | 558.15 KiB |
| 2465853df157c4ad881166804873989c47c10f4d | 1.70 MiB | 2.27 MiB | 583.82 KiB |
| 5e04ee8e63c5617dbc4c2b9706b866e8823cec20 | 1.70 MiB | 2.27 MiB | 584.64 KiB |
| c554ca260c5f0fa79a30d592f6c0e08a850a5014 | 1.70 MiB | 2.27 MiB | 582.25 KiB |
| 4e290632c3083233d83c696533ee1e0d284dfd42 | 1.72 MiB | 2.29 MiB | 578.38 KiB |
| 0404ea31dd7e67983b3aa0133a0dc4fb6b983884 | 1.72 MiB | 2.29 MiB | 577.52 KiB |
| 0404ea31dd7e67983b3aa0133a0dc4fb6b983884 | 1.72 MiB | 2.29 MiB | 577.52 KiB |
Previous results on branch: feat/span-level-measurement
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ead0785063a0a45513f8cf561328456a3e737128 | 492.72 ms | 628.02 ms | 135.30 ms |
| 268afc3f8238ca3a747c60454e60283de5125098 | 407.69 ms | 470.34 ms | 62.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ead0785063a0a45513f8cf561328456a3e737128 | 1.70 MiB | 2.28 MiB | 587.99 KiB |
| 268afc3f8238ca3a747c60454e60283de5125098 | 1.70 MiB | 2.28 MiB | 588.33 KiB |