sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Defaults for Cron - MonitorConfig

Open lbloder opened this issue 1 year ago • 2 comments

:scroll: Description

Allow configuring global default values for checkinMargin, maxRuntime, timezone, recoveryThreshold and failureIssueThreshold of MonitorConfig through SentryOptions.

:bulb: Motivation and Context

Fixes #3122

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

lbloder avatar Feb 06 '24 20:02 lbloder

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 5267adbe1fd5bff299bf0bd6beee66abc4fa6a23

github-actions[bot] avatar Feb 06 '24 20:02 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 406.27 ms 485.45 ms 79.18 ms
Size 1.70 MiB 2.28 MiB 590.90 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8fd337bbd12b54caec15e8ab3dc0f71f02b67d72 349.16 ms 459.22 ms 110.06 ms
86f00968b4ba59f756bb4fe01e4fb1cc61bd4f1d 381.33 ms 476.58 ms 95.25 ms
2a3dd50f5f4d554d9e7340cd86a48e96556a1481 363.61 ms 440.18 ms 76.57 ms
2465853df157c4ad881166804873989c47c10f4d 411.39 ms 461.10 ms 49.72 ms
5e04ee8e63c5617dbc4c2b9706b866e8823cec20 380.63 ms 501.84 ms 121.21 ms
c554ca260c5f0fa79a30d592f6c0e08a850a5014 364.98 ms 433.64 ms 68.66 ms
4e290632c3083233d83c696533ee1e0d284dfd42 376.38 ms 390.98 ms 14.60 ms
a3c77bc887d1ba2e290ffd4da391666449c7b030 375.80 ms 445.85 ms 70.06 ms
4e260b39672c0cc6383209cec9f3300ac5596e36 378.73 ms 454.18 ms 75.45 ms
eecfab66653797e0df6eded59f2c1b28b32243e8 399.27 ms 461.82 ms 62.55 ms

App size

Revision Plain With Sentry Diff
8fd337bbd12b54caec15e8ab3dc0f71f02b67d72 1.72 MiB 2.27 MiB 555.00 KiB
86f00968b4ba59f756bb4fe01e4fb1cc61bd4f1d 1.72 MiB 2.29 MiB 576.50 KiB
2a3dd50f5f4d554d9e7340cd86a48e96556a1481 1.72 MiB 2.27 MiB 555.05 KiB
2465853df157c4ad881166804873989c47c10f4d 1.70 MiB 2.27 MiB 583.82 KiB
5e04ee8e63c5617dbc4c2b9706b866e8823cec20 1.70 MiB 2.27 MiB 584.64 KiB
c554ca260c5f0fa79a30d592f6c0e08a850a5014 1.70 MiB 2.27 MiB 582.25 KiB
4e290632c3083233d83c696533ee1e0d284dfd42 1.72 MiB 2.29 MiB 578.38 KiB
a3c77bc887d1ba2e290ffd4da391666449c7b030 1.72 MiB 2.29 MiB 577.53 KiB
4e260b39672c0cc6383209cec9f3300ac5596e36 1.72 MiB 2.27 MiB 554.95 KiB
eecfab66653797e0df6eded59f2c1b28b32243e8 1.72 MiB 2.27 MiB 558.56 KiB

Previous results on branch: feat/cron-defaults

Startup times

Revision Plain With Sentry Diff
4f3fae88315ed3cd8e9778b75c5e62b970d385db 422.57 ms 497.73 ms 75.15 ms
d4fa6bc347fd89c5881f5669c9ace62649593289 413.08 ms 499.18 ms 86.10 ms
3565505910ba2788d97128207385055a063e68f7 304.96 ms 351.73 ms 46.78 ms
82e7c8f1e2b50fa8b36f7f4d071c6ff5803849ec 424.41 ms 504.44 ms 80.03 ms

App size

Revision Plain With Sentry Diff
4f3fae88315ed3cd8e9778b75c5e62b970d385db 1.70 MiB 2.27 MiB 584.99 KiB
d4fa6bc347fd89c5881f5669c9ace62649593289 1.70 MiB 2.27 MiB 586.75 KiB
3565505910ba2788d97128207385055a063e68f7 1.70 MiB 2.28 MiB 588.45 KiB
82e7c8f1e2b50fa8b36f7f4d071c6ff5803849ec 1.70 MiB 2.27 MiB 584.80 KiB

github-actions[bot] avatar Feb 06 '24 20:02 github-actions[bot]