sentry-java
sentry-java copied to clipboard
getsentry
Android 13 ui tests
:scroll: Description
This pr is still a draft: Saucelabs has issues with its Android 13 devices (they are never available). As soon as Saucelabs fixes it, we will merge it into master We added an Android 13 device on the Saucelabs suite running ui tests
#skip-changelog
:bulb: Motivation and Context
We want to make sure the Android sdk works correctly on the latest Android version, currently 13
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed the submitted code
- [ ] I added tests to verify the changes
- [ ] I updated the docs if needed
- [x] No breaking changes
:crystal_ball: Next steps
@stefanosiano I'd also build the app using compile and target 33, otherwise, it does not test the SDK compatibility as well.
@marandaneto yeah, this is meant to be merged after https://github.com/getsentry/sentry-java/pull/2251
Maybe i can change the base to android_target_sdk_33?
Codecov Report
Base: 80.10% // Head: 80.11% // Increases project coverage by +0.01% :tada:
Coverage data is based on head (
34ddc64) compared to base (4dd88fe). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## main #2252 +/- ##
============================================
+ Coverage 80.10% 80.11% +0.01%
- Complexity 3423 3426 +3
============================================
Files 242 242
Lines 12692 12696 +4
Branches 1698 1698
============================================
+ Hits 10167 10172 +5
+ Misses 1882 1881 -1
Partials 643 643
| Impacted Files | Coverage Δ | |
|---|---|---|
| sentry/src/main/java/io/sentry/Baggage.java | 82.58% <0.00%> (+0.46%) |
:arrow_up: |
| sentry/src/main/java/io/sentry/HubAdapter.java | 9.52% <0.00%> (+1.58%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I had to put two beta versions: androidx.test:core:1.5.0-beta01 and androidx.test:core-ktx:1.5.0-beta01
Should we wait for them to be released in stable (1.5.0) or can we just go with beta and then change them to stable as it is available?
These dependencies are used only in ui tests and benchmarks, so other modules of the sdk are unaffected
I had to put two beta versions:
androidx.test:core:1.5.0-beta01andandroidx.test:core-ktx:1.5.0-beta01Should we wait for them to be released in stable (1.5.0) or can we just go with beta and then change them to stable as it is available? These dependencies are used only in ui tests and benchmarks, so other modules of the sdk are unaffected
I think it's fine since those are test deps 👍
