sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Missing unit fields for Android measurements

Open marandaneto opened this issue 3 years ago • 1 comments

:scroll: Description

Added missing unit field. Added support for unknown fields in case new types come from Hybrid SDKs.

:bulb: Motivation and Context

Fix https://github.com/getsentry/sentry-java/issues/2150 Part of https://github.com/getsentry/team-mobile/issues/31

:green_heart: How did you test it?

:pencil: Checklist

  • [X] I reviewed the submitted code
  • [X] I added tests to verify the changes
  • [ ] I updated the docs if needed
  • [X] No breaking changes

:crystal_ball: Next steps

marandaneto avatar Aug 04 '22 10:08 marandaneto

This has to change, making a draft for now.

marandaneto avatar Aug 04 '22 14:08 marandaneto

@marandaneto, this PR has been lying around for a while. What can we do to move it forward?

philipphofmann avatar Aug 31 '22 07:08 philipphofmann

@marandaneto

This has to change, making a draft for now.

Should be fixed now. Do you want to give my changes a review or can I merge this? Would need it for measurements.

adinauer avatar Sep 02 '22 10:09 adinauer

@marandaneto

This has to change, making a draft for now.

Should be fixed now. Do you want to give my changes a review or can I merge this? Would need it for measurements.

All good from my side, I can't approve my own PR, feel free to fix the conflicts and merge it, thanks for fixing this.

marandaneto avatar Sep 05 '22 06:09 marandaneto