sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Set current thread flag in SentryThreadFactory

Open adinauer opened this issue 3 years ago • 3 comments

:scroll: Description

Sets the current thread flag in SentryThreadFactory

:bulb: Motivation and Context

Found via https://github.com/getsentry/sentry-java/issues/2047 but may not be the cause of that problem.

:green_heart: How did you test it?

Unit Test

:pencil: Checklist

  • [x] I reviewed the submitted code
  • [x] I added tests to verify the changes
  • [ ] I updated the docs if needed
  • [ ] No breaking changes

:crystal_ball: Next steps

adinauer avatar May 13 '22 13:05 adinauer

Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Set current thread flag in SentryThreadFactory ([#2048](https://github.com/getsentry/sentry-java/pull/2048))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against 39b84501d042c5704b788f3191120ac65a8a0ae5

github-actions[bot] avatar May 13 '22 13:05 github-actions[bot]

Do we want this behaviour? https://github.com/getsentry/sentry-java/issues/2047 is fixed without requiring this change.

adinauer avatar May 16 '22 10:05 adinauer

sorry I'm out of context here, maybe @marandaneto can take a quick look

romtsn avatar May 18 '22 06:05 romtsn

I'm gonna close this until we figure https://github.com/getsentry/team-mobile/issues/47 out and then either reopen it or start a new PR.

romtsn avatar Apr 20 '23 07:04 romtsn