sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

PoC radiography integration

Open marandaneto opened this issue 3 years ago • 3 comments

#skip-changelog

That's just a PoC of radiography as an attachment. Ideally Sentry UI would render that nicely.

It should be a separate package since it needs to add the com.squareup.radiography:radiography dependency. We can check at runtime if it's available in the classpath and add the integration automatically. The package should also be installed automatically with the SAGP if radiography is in the classpath. Support for Jetpack compose depends on androidx.compose.ui:ui-tooling in the classpath, that can also be added automatic if compose is in the classpath.

Closes https://github.com/getsentry/sentry-java/issues/1647

marandaneto avatar Apr 20 '22 13:04 marandaneto

Codecov Report

Merging #1998 (067e596) into 6.x.x (bd2a665) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              6.x.x    #1998   +/-   ##
=========================================
  Coverage     80.71%   80.71%           
  Complexity     3039     3039           
=========================================
  Files           217      217           
  Lines         11226    11226           
  Branches       1503     1503           
=========================================
  Hits           9061     9061           
  Misses         1600     1600           
  Partials        565      565           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd2a665...067e596. Read the comment docs.

codecov-commenter avatar Apr 20 '22 13:04 codecov-commenter

radiography

That's what it'd look like.

marandaneto avatar Apr 21 '22 07:04 marandaneto

Ideally, the file format would match with the radiography on iOS, so Sentry UI could prettify and offer features like collapsing, etc...

marandaneto avatar Apr 22 '22 06:04 marandaneto

Closing in favour of #2440

romtsn avatar Jan 03 '23 11:01 romtsn