sentry-dotnet

sentry-dotnet copied to clipboard

The following code looks like a return is missing:

https://github.com/getsentry/sentry-dotnet/blob/bd62cf0421cc7a5d7b7804f8461fae00d47d43b8/src/Sentry/Internal/SdkComposer.cs#L61-L72

Originally, the comment got out of sync in this PR: https://github.com/getsentry/sentry-dotnet/pull/2784/files#diff-77b9274c57c77def047f936ba8b349866e9ca9f7cb48ab9e3ca653b106f11881L45-L48

and the code seems to have been broken since: https://github.com/getsentry/sentry-dotnet/pull/2961/files#diff-0361d7be7721215f1afa7ac6842e0bd3aa5647b093bf80433fe4a2ebd1c2b0f7L12-L16

Oh, actually it just looks like the comment should move here: https://github.com/getsentry/sentry-dotnet/blob/6274944d00826b0442d038f675f4f46ac0fec182/src/Sentry/SentryOptions.cs#L225-L229

or just reintegrate that function back to SdkComposer