raven-python icon indicating copy to clipboard operation
raven-python copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Allow `extra` to be None in breadcrumbs processing

Open joker-at-work opened this issue 6 years ago • 3 comments

Sometimes, extra is passed in as a default parameter of another function and can therefore be None. This fixes:

Traceback (most recent call last):
  File "raven/breadcrumbs.py", line 77, in get_buffer
	processor(payload)
  File "raven/breadcrumbs.py", line 143, in processor
	data_value.update(extra)
TypeError: 'NoneType' object is not iterable

joker-at-work avatar Nov 02 '18 13:11 joker-at-work

The issue addressed by this PR is preventing my team from upgrading to 6.10.0. The issue in my particular project arises when calling captureMessage (that I know of - I haven't exhaustively testing every call in my project) without extra, so I'm not sure where extra is being defaulted to None but it would seem to be between captureMessage and breadcrumb processing.

david-volantio avatar Jun 11 '20 18:06 david-volantio

@david-volantio if you are able to upgrade, any reason for not being able to give the new sdk a go? https://github.com/getsentry/sentry-python

ashwoods avatar Jun 11 '20 21:06 ashwoods

@ashwoods a fair point - I was just hoping we could move to the latest release but updating to sentry-python is definitely on our roadmap. thanks!

david-volantio avatar Jun 12 '20 10:06 david-volantio