action-release

action-release copied to clipboard

So I forked the project yesterday to add some missing parameters and I ran yarn run all to make sure my cloned copy before starting was passing tests, etc.

The command failed.

➜  action-release git:(master) yarn run all 
yarn run v1.22.17
$ yarn run format && yarn run lint && yarn run build && yarn test
$ prettier --write **/*.ts
__tests__/main.test.ts 130ms
src/cli.ts 14ms
src/main.ts 10ms
src/options.ts 18ms
$ eslint src/**/*.ts

/Volumes/Nexus/Github/action-release/src/cli.ts
  1:20  error  'SentryCliReleases' is defined but never used  @typescript-eslint/no-unused-vars

✖ 1 problem (1 error, 0 warnings)

So then I wondered how PRs were getting merged. They don't seem to be running lints or tests at all. The test workflow just runs the action itself in MOCK mode. Was it an oversight that no CI workflow actually runs and enforces Linting/Testing?

@iBotPeaches Thanks for pointing this out. This repository hasn't seen much attention in a while and I'm willing to guess that the test suite or tests themselves are simply out of date. I noticed it as well when merging a docs PR yesterday, in which CI failed.

I've added a ticket in our backlog for our team to add proper tests and repair the flaky CI.

Was it an oversight that no CI workflow actually runs and enforces Linting/Testing?

As to this point, I can't speak to the intentions of the test workflow as it was originally authored, but I do share your concerns that we should have proper linting/tests to run prior to making any changes. I will link out to this issue in our internal ticket and hopefully raise its priority. Thanks for notifying us!