TypL

TypL copied to clipboard

Bug report

Checker tests keep failing on my end:

> [email protected] test /home/mohamededrah/Projects/Oss/TypL
> node scripts/node-tests.js


**********************************
********** TESTING SRC ***********
**********************************

TypL Test Suite (36)

Passed: 'Runtime: API' (14/14)
Passed: 'Runtime: any(..)' (4/4)
Passed: 'Runtime: undef(..)' (10/10)
Passed: 'Runtime: nul(..)' (11/11)
Passed: 'Runtime: string(..)' (8/8)
Passed: 'Runtime: bool(..)' (10/10)
Passed: 'Runtime: number(..)' (10/10)
Passed: 'Runtime: finite(..)' (11/11)
Passed: 'Runtime: int(..)' (13/13)
Passed: 'Runtime: bint(..)' (13/13)
Passed: 'Runtime: symb(..)' (10/10)
Passed: 'Runtime: array(..)' (11/11)
Passed: 'Runtime: array(..), parse shapes only' (8/8)
Passed: 'Runtime: array(..), shape parse failure' (10/10)
Passed: 'Runtime: array(..), shape: int[]' (8/8)
Passed: 'Runtime: array(..), shape: <int[][],string>[]' (10/10)
Passed: 'Runtime: object(..)' (10/10)
Passed: 'Runtime: func(..)' (10/10)
Passed: 'Runtime: regex(..)' (9/9)
Passed: 'Checker: API' (1/1)
Passed: 'Checker: #6 number sub-types' (2/2)
Passed: 'Checker: #7 enforce bool type check in conditionals' (2/2)
Passed: 'Checker: #8 any' (2/2)
Passed: 'Checker: #9 undef' (2/2)
Passed: 'Checker: #17 Narrower number type inference' (2/2)
Passed: 'Checker: #33 Treat IIFE as a validated call-expression' (2/2)
Passed: 'Checker: #34 check tagged-type simple literals' (2/2)
Passed: 'Checker: #39 array-of-type annotation' (1/1)
Passed: 'Checker: #39 Non-empty arrays ' (1/1)
Passed: 'Checker: #39 Non-empty arrays' (1/1)
Failed: 'Checker: #39 Array of various types (union types)' (1/1)
  num errors
    expected: 1
    actual: 2
Failed: 'Checker: #39 multidimensional arrays' (1/1)
  num errors
    expected: 0
    actual: 1
Failed: 'Checker: #39 Tuple, Nested Tuple' (1/1)
  num errors
    expected: 1
    actual: 2
Failed: 'Checker: #39 Array of tuples' (1/1)
  num errors
    expected: 0
    actual: 1
Failed: 'Checker: #39 Tuple of arrays' (1/1)
  num errors
    expected: 0
    actual: 1
Failed: 'Checker: #39 Array of tuples of arrays' (1/1)
  num errors
    expected: 0
    actual: 1

Failed (6/214)

**********************************
********** TESTING SRC ***********
**********************************

npm ERR! Test failed.  See above for more details.

this happens after i run npm install

I did some exploring it seems that the tests (at least for me) start failing at commit 8286faf664bafa36c16d17964142e4fee61fd581
is this a problem on my end or are the test broken ?, i really like this project and would like to contribute if possible, thanks.

How to reproduce

Clone this repo: https://github.com/MSE99/TypL and run npm install

Additional information

os: Pop!_OS 20.04 (An ubuntu based linux distro) node version: 14.16.1 npm version: 6.14.1 typL version: I'm running the tests on the master branch on the latest commit.

I think it's entirely plausible that the tests are in a failing state, especially as it relates to that work around complex array types.

Would love help! Haven't looked at this project in a while so I need to get re-acquainted with it to give more detailed diagnosis. Will try to get to it ASAP.

@getify Sorry for the late reply, most of the broken tests test multidimensional array types with union types and tuples most of the logic that handles this is not implemented yet, any idea on where or how to start implementing them ?.