Dave Smith

Results 182 comments of Dave Smith

> hover/focus/active states Here's [the Dev Note](https://github.com/WordPress/gutenberg/pull/41786#issuecomment-1254694174) for this.

> As mentioned in the PR it ended up being bigger than expected. I noted this. Understood. It's a tricky balance.

> Also, that PR was pretty huge, I don't really get why I had to divide this PR up into smaller parts. 🤷 I believe the reason that PR was...

Whatever we do here has to include changes from https://github.com/WordPress/gutenberg/pull/42182 in order to ensure they work together.

@draganescu I think we need to ensure we add a dev note for this one. The change I wrote about [here](https://github.com/WordPress/gutenberg/pull/42182) which got merged into this PR means that any...

I don't see a reason why we need it. We can deprecate it.

@jasmussen In light of recent updates to the UI (and the upcoming addition of [a settings "drawer"](https://github.com/WordPress/gutenberg/pull/47328)) should we consider making _any_ changes to the link require clicking `Apply`? This...

Now https://github.com/WordPress/gutenberg/pull/47328 is merged we can look to make this happen.

This was fixed in https://github.com/WordPress/gutenberg/pull/50668

I have cherry picked this PR into the `wp/6.5` branch so that the cherry picking script will function as intended for the Beta 3 today.