Dave Smith

> Any reason for not calculating `isDistractioFree` value during the render? > > Something like this: > > ```js > const isDistractionFree = isDistractionFreeMode && isLargeViewport > ``` > >...

> Any reason for not calculating `isDistractioFree` value during the render? > > Something like this: > > ```js > const isDistractionFree = isDistractionFreeMode && isLargeViewport > ``` > >...

This is very rough and still a PoC. We need to - refine the DOM structure/tab ordering. - fix the auto-commit behaviour of the Open in new tab (this is...

> It might not be so bad in practise though, perhaps worth a try? I can give this a go.

https://user-images.githubusercontent.com/444434/214929120-333838c9-eb38-4c06-a74a-b8e8ed892409.mp4 I updated so that the drawer is below the button as per the design @jameskoster provided. The one issue with this is the tab order. I was speaking away...

> I think that animation could be sped up a little, though. .2s seems good. @jasmussen I changed this to 0.2s. It feels little janky I think because some of...

> You mentioned this in https://github.com/WordPress/gutenberg/pull/47328, but definitely would be good to fix the tab sequence. In general, a toggle should be in the DOM before the controlled content. This...

@jasmussen @jameskoster I've: - updated the animation to be less janky - fixed spacing - fixed tab ordering - reset animation speed (probably best not to rely on the video...

@scruffian Thanks for the ✅. I found one UX question which is outstanding. What happens if you are not editing the link but you toggle the settings and then change...

I pushed an update which only shows settings controls _if_ we are in "edit" mode. I will need to add a test for this.