nimgen icon indicating copy to clipboard operation
nimgen copied to clipboard

Published 20 hours ago • verified publisher icon genotrance

Error when using `main` as master-branch

Open ThomasTJdev opened this issue 4 years ago • 3 comments

Currently the branch master is hardcoded, but with recent changes to Github we now see people using the name main instead. This is a problem for my library https://github.com/ThomasTJdev/nimlibxlsxwriter/issues/1.

The hardcoded master is located here. https://github.com/genotrance/nimgen/blob/7662523501b00f35dcaab1af50481a3bacfce5f1/src/nimgen/external.nim#L82-L90

ThomasTJdev avatar May 11 '21 03:05 ThomasTJdev

Also running into this exact problem and thinking perhaps this should be configurable?

joshgoebel avatar Sep 01 '21 13:09 joshgoebel

Hi @joshgoebel

My PR https://github.com/genotrance/nimgen/pull/50 fixes this and allows for custom branch-naming.

But as stated in the nimgen README it has been deprecated..

Nimgen has been superseded by nimterop. Existing wrappers are slowly being migrated over to nimterop. No new features will be implemented going forward.

ThomasTJdev avatar Sep 01 '21 13:09 ThomasTJdev

Arguably, nimterop is also dead since I'm no longer maintaining either project. Considering c2nim is still being actively developed, I'm open to PRs and owners for nimgen. Somehow I didn't get a notification for the PR, just merged.

genotrance avatar Sep 01 '21 13:09 genotrance