gear icon indicating copy to clipboard operation
gear copied to clipboard

Implement RPC getter of program pages

Open breathx opened this issue 3 years ago • 2 comments

breathx avatar Oct 06 '22 11:10 breathx

Codecov Report

Base: 71.47% // Head: 71.35% // Decreases project coverage by -0.11% :warning:

Coverage data is based on head (aa84238) compared to base (c893ced). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   71.47%   71.35%   -0.12%     
==========================================
  Files         105      105              
  Lines        9969     9984      +15     
==========================================
- Hits         7125     7124       -1     
- Misses       2844     2860      +16     
Impacted Files Coverage Δ
pallets/gear/rpc/src/lib.rs 0.00% <0.00%> (ø)
core-processor/src/executor.rs 89.62% <0.00%> (+1.60%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 06 '22 12:10 codecov[bot]

we can remove the gpages api from gprogram also after this implementation

  • api: https://github.com/gear-tech/gear/blob/c893ced2a136f25cb9e28f84a723d8453da3507e/program/src/api/storage.rs#L86
  • parser: https://github.com/gear-tech/gear/blob/c893ced2a136f25cb9e28f84a723d8453da3507e/program/src/api/utils.rs#L13

clearloop avatar Oct 06 '22 13:10 clearloop

Will be unused since new concept of metadata

breathx avatar Oct 20 '22 19:10 breathx