geany-plugins
geany-plugins copied to clipboard
geany
Numbered Bookmarks - Modified File Notification-Dialog may be Excessive (and may not be necessary)
I've noticed that the accept/reject notification dialog is displayed for files which have been modified outside of geany (which may or may not have been changed), at least I don't remember having made changes, outside of geany.
I find my self just clicking ignore (which seems to be often) and just moving on.
I'm wondering if:
- The notification dialog is really necessary? (eg. could it just force the rejection and log a status message)
- or maybe the display of the notification dialog could be a plugin configuration option (if it is disabled -- then maybe it could be auto-rejected like in the first part and perhaps that could be configured as well)
Long story short -- I really don't think displaying a modal notification, when a file is loaded, is really necessary when all someone may want to do is load the standard bookmarks (which to my knowledge aren't serialized/loaded by geany--meaning this plugin is required for that) while also being able to get back to editing files without needing to click through the dialog(s).
This following code blob in geanynumberedbookmarks.c is responsible for showing the dialog:
https://github.com/geany/geany-plugins/blob/ddf06e8a1ce945a9d3dbdf482dc9aeb8478f080c/geanynumberedbookmarks/src/geanynumberedbookmarks.c#L967-L981
