fp-ts feat(Apply/ap): make total overloads `F: 0,1,2,2C,3,3C,4` to `G: 1,2,2C,3,3C,4`

feat(Apply/ap): make total overloads `F: 0,1,2,2C,3,3C,4` to `G: 1,2,2C,3,3C,4`

Open waynevanson opened this issue 3 years ago • 3 comments

There are some overloads missing that I needed in in my projects, and figured we may as well add all the overloads for the functions.

Questions:

What is preferred, A => B or A1 => A2? I prefer the latter because there's no good standard on letters after Q.
Could we do A1 instead of A? I've been using vim search and replace and it's much easier when they all have numbers.

Jun 11 '22 23:06 waynevanson

@gcanti Could I get a rerun on this one?

Jun 12 '22 12:06 waynevanson

@gcanti Please review when you get the chance, it ran.

Jul 25 '22 13:07 waynevanson

What is preferred, A => B or A1 => A2?

For consistency with all the other signatures I'd keep A => B

Aug 05 '22 06:08 gcanti

What is preferred, A => B or A1 => A2?

For consistency with all the other signatures I'd keep A => B

@gcanti I've used the Functor module as the reference for the syntax.

Aug 14 '22 07:08 waynevanson