github-action-markdown-link-check icon indicating copy to clipboard operation
github-action-markdown-link-check copied to clipboard

Add cookie support between redirects

Open jonatan-ivanov opened this issue 2 years ago • 3 comments

There are sites that are sending a redirect with a cookie if the request does not have one, for examlpe Twitter started doing this, so those links are now marked as broken even if they are not:

echo 'https://twitter.com' |  markdown-link-check

You can also verify this with curl, this should fail:

curl --verbose --location 'https://twitter.com'

But if you enable cookies, it works:

curl --verbose --location --cookie --junk-session-cookies 'https://twitter.com'

Workaround: sending some static cookies in the headers but having support for this would be nice, since sites can change the cookies they mandate any time. See: https://github.com/jonatan-ivanov/develotters-blog/commit/727cfd5a7f200014ba6cae9b756a6fcb329fd4de

jonatan-ivanov avatar May 13 '23 07:05 jonatan-ivanov

I have stopped working on this action. Please try https://github.com/UmbrellaDocs/linkspector and https://github.com/UmbrellaDocs/action-linkspector instead.

gaurav-nelson avatar May 14 '24 12:05 gaurav-nelson

Thank for the answer. Please consider the followings:

  • Moving this repo to the new project if it does not have this capability already
  • Archiving this repo and calling out in the readme that it is unmaintained
  • Removing it from the GitHub Actions Marketplace

jonatan-ivanov avatar May 15 '24 17:05 jonatan-ivanov

Thank you @jonatan-ivanov I'll plan that.

gaurav-nelson avatar May 16 '24 01:05 gaurav-nelson