laravel_mpesa icon indicating copy to clipboard operation
laravel_mpesa copied to clipboard

Published 20 hours ago • verified publisher icon gathuku

[enhancement] Set minimum version to `illuminate/support": "^8`

Open jwambugu opened this issue 3 years ago • 2 comments

The package currently requires "illuminate/support": "^5.0|^6.0|^7.0|^8.0" which pulls in versions ^5.0|^6.0|^7.0 which might not be getting any security fixes.

Can we have another version which will require the minimum version of illuminate/support to be ^8. This will ensure new projects or updates which satisfy this requirement will also get the security fixes.

jwambugu avatar Dec 09 '21 17:12 jwambugu

@jwambugu The only support component am using is File::get Maybe rewriting this to get rid of the File support component can be the best. How do you think? https://github.com/gathuku/laravel_mpesa/blob/master/src/Mpesa.php#L137-L146

gathuku avatar Dec 09 '21 19:12 gathuku

The whole support package provided a lot of functionality which we can extend to use and refactor this package. And since it's a laravel package, I feel it should remain. That's my opinion 😁

jwambugu avatar Dec 10 '21 05:12 jwambugu