k3s-oci-cluster

k3s-oci-cluster copied to clipboard

This PR refactors some of the resources to create a k3s_primary_server which is then used to optionally deploy the OCI Cloud Controller Manager to the cluster. This is disabled by default.

A terraform.tfvars.sample is provided in the example/ folder to explain some of the new/changed/removed variables.

Signed-off-by: Avi Miller [email protected]

FYI, I forgot to add the new variables to the table in README.md

Wow that's a lot of new features 👍 I think I will split this PR in two sub PR:

• OS choice Ubuntu/Oracle Linux
• CCM installation

Please don't delete your branch so I can create the new feature branches. Stupid question: the OCI Cloud Controller Manager is compatible with Ubuntu right?

Good call. :)

OCI CCM should work on both distros, but I don't think I've tested it on Ubuntu on Arm. If it doesn't, I'll raise that with the CCM team.

Are this file missing in your branch?

• "files/oci-cloud-controller-manager.yaml"
• "files/oci-cloud-controller-manager-rbac.yaml"

No, they're embedded in k3s-server-install.sh because it was easier than trying to ship them with Terraform.

This resource "null_resource" "oci_ccm_config" is required?

Nope, that's embedded too. I was playing with a bunch of things, and must've forgotten to remove those. I've just found another issue I hadn't considered (the case when expose_kubeapi is true) so give me a couple of days to fix this and clean the rest up.

Nope, that's embedded too. I was playing with a bunch of things, and must've forgotten to remove those. I've just found another issue I hadn't considered (the case when expose_kubeapi is true) so give me a couple of days to fix this and clean the rest up.

Hey @Djelibeybi @garutilorenzo, wondered if OCI CCM ever got calved out and implemented?

Hi @mannp CCM is in roadmap. I will open a new PR ASAP

Hi @mannp CCM is in roadmap. I will open a new PR ASAP

HI @garutilorenzo thanks for clarifying, appreciated.