garethr-docker

garethr-docker copied to clipboard

The garethr-docker module v5.2.0 is installed by puppetlabs-docker_platform v2.1.0. It generates a number of deprecation warnings on Puppet 3.8.5 when running class { 'docker': } or docker::image, including:

Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera defaults Warning: Scope(Apt::Source[docker]): $include_src is deprecated and will be removed in the next major release, please use $include => { 'src' => false } instead Warning: Scope(Apt::Source[docker]): $required_packages is deprecated and will be removed in the next major release, please use package resources instead. Warning: Scope(Apt::Source[docker]): $key_source is deprecated and will be removed in the next major release, please use $key => { 'source' => http://apt.dockerproject.org/gpg } instead. Warning: Scope(Apt::Key[Add key: 58118E89F3A912897C070ADBF76221572C52609D from Apt::Source docker]): $key_source is deprecated and will be removed in the next major release. Please use $source instead.

On the surface, it looks like the errors are being thrown by the APT module, but the source of the problem is actually in the way that the Docker module is invoking Apt::Source and Apt::Key.

Still there for version 5.3.0

As of puppetlabs-apt 4.0.0, this now throws an error.

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation 
Error: Error while evaluating a Resource Statement, Apt::Source[docker]:
  has no parameter named 'key_source'
  has no parameter named 'required_packages'
  has no parameter named 'include_src' at /etc/puppetlabs/code/environments/production/external-modules/docker/manifests/repos.pp:20 on node host.example.com
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

@garethr There are now at least 6 PRs that try to fix this very issue:

1. #461
2. #528
3. #595
4. #634
5. #675
6. #693

None has been merge until today. Why?

+1 @bittner

Please merge the fix.

my ubuntu 16.04 VM with puppet 3.8.5 and the garethr-docker v5.3.0 generates no warnings but an error:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type apt::source at /etc/puppet/modules/docker/manifests/repos.pp:34 on node puppetagentone.local

I've already done @costela s changes- still the same error..

info: now i use puppet 4 and the official "docker_platform" puppet module(still on ubuntu 16.04) and it works.

@BlauerPulli Note that the docker_platform module is nothing else than this repo. The former is really just a meta-package. See the sources to prove this.

When it works for you you're lucky. For everyone else this module is broken. For years.