node-libtidy

node-libtidy copied to clipboard

As described in #24.

Closes #24.

Builds were failing due to an issue with nan that was resolved in 2.11.0: https://github.com/nodejs/nan/issues/766, so I updated that too.

This is passing on Node versions > 4 on Travis, but seems to be failing on AppVeyor Node version 5. 🤷‍♂️

Both of the failures are not related to the content of this PR:

C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js:85
      let notifier = require('update-notifier')({pkg})
      ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:148:18)
    at node.js:405:3

Seems like a AppVeyor infrastructure specific thing.

Anyway, this has become an issue again for us, and has previously caused us to delay moving to the latest LTS Node, so we've temporarily published libtidy-updated (it's difficult/impossible to add it as a git dependency, as it has git submodules in there).

Anyone up the chain ready to look at this PR?

this fixed my problem! thanks!

This would solve compilation problems with Node v13. Any chance the PR could be merged?